I have this beautiful "smith" fig tree, which I don't think it is, a have a real smith from a very reputable figger, but the one in question is 4 yrs old has beautiful scaffolding I love its shape, but it doesn't produce figs! This is it's 4th year and it has 1 fig on it! I haven't gotten a fig yet this is the 1st one ever! Are there known varieties that just suck at producing? What varieties is this indicative of? Don't know if I should give it more time or just trash it! And yes I pinched all the tops!

Same here for my supposedly "green Ischia" fig tree.  I got it as an 1' tall tree in pot, and then planted it in ground in 10/2015.  Now it is about 6' tall with several major trunks after I pinched it a month ago.  Funny thing is that I only have six figs for a tree this large, all on the lower section of the branches(the first time ever).  My neighbor's tree (a Celeste?) produces hundreds of figs from every nodes of the branches, large and small.  Mine just shows nodes that do nothing, except the top portion of the pinched branches where new branches broke out of the nodes.  I am puzzled as well as to why such a difference between my neighbor's tree and mine. 

Even if you get a prolific variety, there are some factors that will affect productivity such as age, type of soil used, fertilizer, zone, location etc.. and not all trees equally deliver.
A fig tree might produce one season and do absolutely nothing the following leaf, but the most important thing that I found when it came to producing fruit was age. Some trees will simply not produce before four or five years no matter what you do to them and there are certain varieties that are not mean for pots and with these, I found that the size of pot matters. The larger the better, but at some point it becomes impractical.

Celeste is known for its productivity, and for me it's among my top producing trees in pot and I'm sure if put in ground, since this tree "Appears to be the most cold hardy of all fig varieties that have been evaluated in Texas" as mentioned by TX A&M

http://aggie-horticulture.tamu.edu/fruit-nut/files/2015/04/figs_2015.pdf

The only problem that I have with the Celeste is the fruit size, but that's a minor issue considering many of my trees don't produce anything for one year and many still have to produce.
Growing a fig tree is a long term investment, but in the end you want to eat some figs. The right Celeste is a reliable tree and in the last five years production keeps increasing and there's nothing wrong with the flavor.
It's a top tasting fig.

I am hoping that comes next spring, my green Ischia will have a lot of breba figs if these nodes do not break out at all.  I think this tree is more than four years old, judging from the size of the trunks at the base, about 1.25" in diameter.  It is a vigorous grower with the branches at the top about 3/8" thick. 

I'd rather have medium to large fig fruits than small ones.  Seem like too much work for me to cover them with organza bags or pick them higher up.  Blue berries come to mind which took me forever to pick one gallon of fruits in the hot Summer days.  I eventually stop doing U-pick blue berry a while back.

I have Smith in Z6 RI, and it produces well.  It definitely does not "suck" as a producer.

Where do you live?  It's been a cold, cloudy spring here, and none of my potted trees started to show figs until warm weather arrived roughly a week ago.  The early/midseason varieties now have figs.  Smith now has lots of small figs, the size of bb's to small peas.  If you are in a cold area, I'd say be patient.

But FWIW, I think you pinched prematurely.  It seems to me that the main point off pinching is to prevent the tree from setting fruit that will never ripen -- pushing energy into already developing figs.  For Smith, that would mean pinching much later (e.g. August).  By then, you might have 2-4' of growth with figs at almost every leaf node. 

Pinching early seems to retard growth and force branching.  It may accelerate development of a few figs below the pinch, but it seems to reduce, delay or eliminate the possibility of more fruit.  For example, in your 5th picture, I can clearly see a pinched branch with 2 figs and then a new terminal bud.  I have to imagine that if you had not pinched until later, you'd have gotten these two figs plus many more.

I get it now -- but I didn't before -- you don't think it's really a Smith and were trying to figure out what it might be.  OK.  Of course, I have no idea.  I've got about 40 varieties but most are 1-year old cuttings; maybe a dozen or so are older.  Even so, I have had very few trees that were reluctant producers.  A potted Sumacki that I purchased last year seems the slowest.  A Lattarula that I put in-ground also seemed a little slow to get going.  

If anything, I've been surprised by the willingness of new cuttings to produce fruit.  I've got small figs on the following -- all started this year -- LSU IC, BM kk, Nordland, St Rita, Red Lebanese Bekaa, and others.

my Green Ischia from Petals has been a very shy bearer.  Two figs in three years and none showing yet this year, but it is growing faster than before.  i hope its just a long establishment period and will pay off more down the road.